Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_*_preconfigure/Suse: Rework of preconfigure roles for Suse, add missing notes. #930

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Jan 14, 2025

Description

Rework of all preconfigure roles to improve preconfiguration on Suse systems.

Common changes across all 3 roles:

  1. Split var files and update with correct packages for each product. Remove unnecessary obsolete packages and SAP patterns from base SLES.
  2. Add support for SLES_SAP_16 - WIP version.
  3. Rework all assert- code to reflected updated tasks.
  4. Add generic tasks for: saptune install and takeover, GRUB updates
  5. Add handling for packagekit.service which blocks zypper on systems with enabled SLE-Module-Desktop-Applications
  6. Fix default empty variables with correct [] or {}
  7. Remove dependency on python3-rpm by replacing ansible_facts.packages with rpm query.
  8. Move ansible.builtin.package_facts away from main to appropriate tasks, to enable point 7.

sap_general_preconfigure specific

  1. Add 2578899 - SUSE Linux Enterprise Server 15: Installation Note

sap_hana_preconfigure specific:

  1. Remove 1275776 - Linux: Preparing SLES for SAP environments - it is part of saptune generic tasks.
  2. Rework 1944799 - SAP HANA Guidelines for SLES Operating System Installation to remove hardcoded obsolete packages.
  3. Remove 2578899 - SUSE Linux Enterprise Server 15: Installation Note - its part of sap_general_preconfigure
  4. Rework 2684254 - SAP HANA DB: Recommended OS settings for SLES 15 / SLES for SAP Applications 15

sap_netweaver_preconfigure

  1. Add some variables that are in sap_general_preconfigure and sap_hana_preconfigure
  2. Add handlers file, same as sap_general_preconfigure and sap_hana_preconfigure
  3. Change input package variable to correct sap_netweaver_preconfigure_packages
  4. Remove 1275776 - Linux: Preparing SLES for SAP environments - it is part of saptune generic tasks.

Test results

All 3 roles were tested on following systems and platforms:

  • SLES 15 SP 5 on SUSE Rancher VM
  • SLES 15 SP 6 on SUSE Rancher VM
  • SLES_SAP 15 SP 5 on AWS and SUSE Rancher VM
  • SLES_SAP 15 SP 6 on AWS and SUSE Rancher VM

@marcelmamula marcelmamula added the enhancement New feature or request label Jan 14, 2025
@marcelmamula marcelmamula self-assigned this Jan 14, 2025
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will fix the codespell error in a future PR.

@berndfinger berndfinger merged commit c186f3e into sap-linuxlab:dev Jan 23, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants